Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Modify how job success is verified for CI/CD #965

Merged
merged 15 commits into from
Nov 7, 2024
Merged

Conversation

dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Nov 4, 2024

Because of PyMechanical crash on exit (Known limitation : #85), the tests are verified using the outputs stored in text file. This will be fixed from next version of Mechanical and hence updating the jobs if version > 24R2.

@github-actions github-actions bot added maintenance Package and maintenance related ci/cd Involves the GitHub workflow files labels Nov 4, 2024
@dipinknair dipinknair changed the title Test: stable exit of container TEST: stable exit of container Nov 4, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (66e8dd8) to head (b6f5f31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   81.27%   81.23%   -0.05%     
==========================================
  Files          36       36              
  Lines        2302     2302              
==========================================
- Hits         1871     1870       -1     
- Misses        431      432       +1     

@dipinknair dipinknair changed the title TEST: stable exit of container CI: Modify how job success is verified for tests Nov 6, 2024
@dipinknair dipinknair marked this pull request as ready for review November 6, 2024 19:59
@dipinknair dipinknair requested a review from a team as a code owner November 6, 2024 19:59
@koubaa
Copy link
Collaborator

koubaa commented Nov 6, 2024

@dipinknair please also take a look at the @@success@@ stdout workaround in the tests

@dipinknair dipinknair changed the title CI: Modify how job success is verified for tests CI: Modify how job success is verified for CI/CD Nov 7, 2024
@koubaa koubaa merged commit 647d4d2 into main Nov 7, 2024
51 checks passed
@koubaa koubaa deleted the maint/ci-cd-refactor branch November 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Involves the GitHub workflow files documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants