-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Modify how job success is verified for CI/CD #965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
Package and maintenance related
ci/cd
Involves the GitHub workflow files
labels
Nov 4, 2024
dipinknair
force-pushed
the
maint/ci-cd-refactor
branch
from
November 4, 2024 16:41
ab07e07
to
da3effd
Compare
dipinknair
changed the title
Test: stable exit of container
TEST: stable exit of container
Nov 4, 2024
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Nov 4, 2024
…hanical into maint/ci-cd-refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
- Coverage 81.27% 81.23% -0.05%
==========================================
Files 36 36
Lines 2302 2302
==========================================
- Hits 1871 1870 -1
- Misses 431 432 +1 |
dipinknair
changed the title
TEST: stable exit of container
CI: Modify how job success is verified for tests
Nov 6, 2024
@dipinknair please also take a look at the |
dipinknair
commented
Nov 6, 2024
dipinknair
changed the title
CI: Modify how job success is verified for tests
CI: Modify how job success is verified for CI/CD
Nov 7, 2024
koubaa
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/cd
Involves the GitHub workflow files
documentation
Improvements or additions to documentation
maintenance
Package and maintenance related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of PyMechanical crash on exit (Known limitation : #85), the tests are verified using the outputs stored in text file. This will be fixed from next version of Mechanical and hence updating the jobs if version > 24R2.